----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47124/ -----------------------------------------------------------
(Updated May 10, 2016, 9:39 a.m.) Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev. Changes ------- removed commented code Bugs: AMBARI-16266 https://issues.apache.org/jira/browse/AMBARI-16266 Repository: ambari Description ------- Earlier : Uploading csv files with exactly 1 row gives error. This was because "is first row header" was by default assumed to be true, and that left no rows in the file for data. In this patch : "is first row header" is assumed to be false by default. more options added for header option like EMBEDDED and NONE for clear definition. Handled this on UI and backend. Diffs ----- contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java 83eae9b contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseOptions.java adbdf7f contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java d94ad3c contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js d883743 contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs b7d9011 contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java 479c934 contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java 555d8e3 contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java f925dc3 Diff: https://reviews.apache.org/r/47124/diff/ Testing ------- Tests modified to account for change as the header line will not be included into the preview rows returned by parser. Explicit tests added for single row csv, json and xml. Results : Tests run: 101, Failures: 0, Errors: 0, Skipped: 0 File Attachments (updated) ---------------- AMBARI-16266_trunk.patch https://reviews.apache.org/media/uploaded/files/2016/05/10/73f61edb-b15d-4cab-b2f2-96c50d467e8e__AMBARI-16266_trunk.patch AMBARI-16266_trunk_2.patch https://reviews.apache.org/media/uploaded/files/2016/05/10/ca7a4bbf-c56c-4383-8c4b-24b59e3af609__AMBARI-16266_trunk_2.patch Thanks, Nitiraj Rathore