> On May 9, 2016, 7:39 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java,
> >  lines 65-66
> > <https://reviews.apache.org/r/47023/diff/1-2/?file=1373573#file1373573line65>
> >
> >     What was wrong with getName() ? this seems a lot more likely to have 
> > problems

The getName in the remoteAmbariClusterEntity is the nage give by user while 
creating RemoteClusterEntity. This is different from actual name of the cluster 
on Remote Ambari Server. 
The url will be in format like http://host:port:/api/v1/clusters/${clusterName} 
. As the url will always be in format, this should not cause any problem.


- Gaurav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47023/#review132312
-----------------------------------------------------------


On May 10, 2016, 11:10 a.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47023/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 11:10 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Jonathan Hurley, Nitiraj 
> Rathore, Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16274
>     https://issues.apache.org/jira/browse/AMBARI-16274
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Added RemotAmbariClusterEntity, RemoteAmbariClusterDao to store remote 
> cluster credential.
> Added RemoteClusterResourceProvider for accessing Remote Cluster through api.
> Added RemoteAmbariCluster impementation for view.Cluster that can be accessed 
> through ViewContextImpl.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RemoteClusterResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  0b77511 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RemoteClustersService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  4e7a032 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  605f68d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  386e657 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterServiceEntity.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewEntity.java
>  29dc2a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  2d6e5ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariCluster.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariConfigurationReadException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariStreamProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewAmbariStreamProvider.java
>  1dacd92 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
>  ba7f446 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> d2d48a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/configuration/ViewConfig.java
>  bb6a93c 
>   ambari-server/src/main/resources/META-INF/persistence.xml ce563cb 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProviderTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/RemoteAmbariClusterTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/ViewAmbariStreamProviderTest.java
>  8549d4a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/view/configuration/ViewConfigTest.java
>  a41e137 
> 
> Diff: https://reviews.apache.org/r/47023/diff/
> 
> 
> Testing
> -------
> 
> Manual Testing
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Reply via email to