-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47160/#review132511
-----------------------------------------------------------




ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
(line 235)
<https://reviews.apache.org/r/47160/#comment196731>

    +1 for comprehensive test code


- Lav Jain


On May 10, 2016, 7:26 a.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47160/
> -----------------------------------------------------------
> 
> (Updated May 10, 2016, 7:26 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Goutam 
> Tadi, jun aoki, and Lav Jain.
> 
> 
> Bugs: AMBARI-16419
>     https://issues.apache.org/jira/browse/AMBARI-16419
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After move NAMENODE wizard is executed,
> - PXF should be installed on the target host.
> - If the source host does not have a DATANODE, PXF should be removed from the 
> source host.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/reassign/step6_controller.js 
> f718d46 
>   ambari-web/app/messages.js e388526 
>   ambari-web/test/controllers/main/service/reassign/step6_controller_test.js 
> 89e2325 
> 
> Diff: https://reviews.apache.org/r/47160/diff/
> 
> 
> Testing
> -------
> 
> Added unit tests.
> 
>   27727 tests complete (25 seconds)
>   154 tests pending
>   
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 01:14 min
> [INFO] Finished at: 2016-05-10T00:20:54-07:00
> [INFO] Final Memory: 12M/310M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Matt
> 
>

Reply via email to