-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47244/#review132693
-----------------------------------------------------------




ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
 (line 395)
<https://reviews.apache.org/r/47244/#comment196961>

    Why not keep the same thread and just submit task to it?


- Sid Wagle


On May 11, 2016, 5 p.m., Aravindan Vijayan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47244/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 5 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16440
>     https://issues.apache.org/jira/browse/AMBARI-16440
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> HBase Regionserver daemons shuts down and restarts the Metric System for 
> every 5 minutes to make sure there is no growth of metrics. This causes AMS 
> Hadoop sink to lose metrics intermittently, which was buffered during that 
> time. This leads to holes in data and negative rates in graphs.
> 
> 
> Diffs
> -----
> 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  3316a54 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java
>  35b9459 
> 
> Diff: https://reviews.apache.org/r/47244/diff/
> 
> 
> Testing
> -------
> 
> Manually tested.
> 
> Unit tests pending.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Reply via email to