-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47224/#review132836
-----------------------------------------------------------




contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
(line 132)
<https://reviews.apache.org/r/47224/#comment197088>

    Use Ember.isEmpty or Ember.isBlank for this.


- DIPAYAN BHOWMICK


On May 11, 2016, 9:18 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47224/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 9:18 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16443
>     https://issues.apache.org/jira/browse/AMBARI-16443
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - Introduced a settingException variable
> - settingException variable gets the name and value for the failed setting 
> parameter.
> - we display error the error message for the failed setting while saving the 
> settings.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/services/settings.js 
> b813bbf 
> 
> Diff: https://reviews.apache.org/r/47224/diff/
> 
> 
> Testing
> -------
> 
> manually tested
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Reply via email to