-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47252/#review132943
-----------------------------------------------------------




ambari-web/app/messages.js (line 2659)
<https://reviews.apache.org/r/47252/#comment197205>

    a proper grammar is "between X and Y", I believe, not "between X to Y"



ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js (line 
31)
<https://reviews.apache.org/r/47252/#comment197206>

    if the threshold is single, then we don't need 1 at the end of variable 
name.



ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js (line 
111)
<https://reviews.apache.org/r/47252/#comment197209>

    we don't have orange here, do we ?


- Alexander Denissov


On May 11, 2016, 7:04 p.m., Goutam Tadi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47252/
> -----------------------------------------------------------
> 
> (Updated May 11, 2016, 7:04 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, 
> Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16461
>     https://issues.apache.org/jira/browse/AMBARI-16461
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> PXF Agents Live Widget on Dashboard needs custom widget to display only 
> single threshold i.e., Green/Red only
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js c5e1145 
>   ambari-web/app/mixins.js cf8cef6 
>   ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 
>   ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js 
> PRE-CREATION 
>   ambari-web/app/styles/modal_popups.less 5e89dbc 
>   
> ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs
>  PRE-CREATION 
>   ambari-web/app/views.js 127a996 
>   ambari-web/app/views/main/dashboard/widgets.js 38181c0 
>   ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 
>   ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47252/diff/
> 
> 
> Testing
> -------
> 
> Yes, All tests passed. Test was already in place.
> 
> 
> Thanks,
> 
> Goutam Tadi
> 
>

Reply via email to