-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45507/
-----------------------------------------------------------
(Updated May 12, 2016, 9:40 p.m.)
Review request for Ambari, Jayush Luniya, Robert Nettleton, and Yusaku Sako.
Changes
-------
Hi Bob, Jayush,
I have addressed the issues marked below in this patch. Please review and
provide your comments.
Thank you,
Amruta
Bugs: AMBARI-15395 and AMBARI-15406
https://issues.apache.org/jira/browse/AMBARI-15395
https://issues.apache.org/jira/browse/AMBARI-15406
Repository: ambari
Description
-------
Enhance blueprints to export placeholder/token for password properties. This is
to avoid user from having tochange the password once the cluster is formed if a
user wishes to do so.
Secret References acting as tokens to password properties would be replaced by
user with appropriate passwords,
If any Secret references are found during cluster deployment with blueprint,
those will be replaced by default_password provided in blueprint template.
Need more comments to make this feature more portable.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
9cc7b13
ambari-server/src/main/java/org/apache/ambari/server/topology/BlueprintValidatorImpl.java
432c6f8
ambari-server/src/main/java/org/apache/ambari/server/topology/RequiredPasswordValidator.java
98eaa40
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
14a718d
ambari-server/src/test/java/org/apache/ambari/server/topology/BlueprintImplTest.java
0b06eb8
ambari-server/src/test/java/org/apache/ambari/server/topology/RequiredPasswordValidatorTest.java
e8a2ff5
Diff: https://reviews.apache.org/r/45507/diff/
Testing
-------
Tested the patch by trying out blueprint export and creating a cluster from the
exported blueprint. Result was: the password tokens were replaced by default
password and cluster was created successfully.
File Attachments (updated)
----------------
AMBARI-15406.patch
https://reviews.apache.org/media/uploaded/files/2016/03/30/8daa09ee-82e5-4cd8-98d3-b1c00f1269b7__AMBARI-15406.patch
AMBARI-15406-v1
https://reviews.apache.org/media/uploaded/files/2016/05/12/7faf76cc-a42d-4017-b203-8db19448b09d__AMBARI-15406.patch
Thanks,
Amruta Borkar
