-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47321/#review133112
-----------------------------------------------------------



Can you add documentation to all new methods.

Also, I'm curious why we're still using metainfo - we need to move away from 
this and start relying on repo_version


ambari-common/src/main/python/resource_management/core/base.py (line 61)
<https://reviews.apache.org/r/47321/#comment197395>

    An interesting way to provide a set of values in Python 2 ... Can we 
document this?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (lines 878 - 880)
<https://reviews.apache.org/r/47321/#comment197397>

    Should we do this before calling getRepository?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 882)
<https://reviews.apache.org/r/47321/#comment197399>

    Null check for the ri ?



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 888)
<https://reviews.apache.org/r/47321/#comment197400>

    StringUtils.isBlank(newBaseUrl)



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 898)
<https://reviews.apache.org/r/47321/#comment197402>

    Why are we still using MetaInfo here? It seems like we need to stop using 
this table for repos and just use repo_version instead.



ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 (line 951)
<https://reviews.apache.org/r/47321/#comment197403>

    Documentation.



ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (line 3908)
<https://reviews.apache.org/r/47321/#comment197404>

    default ?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
 (line 191)
<https://reviews.apache.org/r/47321/#comment197410>

    StringUtils.isBlank() to protect against an accidental ""



ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryHelper.java
 (lines 34 - 35)
<https://reviews.apache.org/r/47321/#comment197413>

    Hard coded values for this could lead to a deployment loss of service.


- Jonathan Hurley


On May 12, 2016, 12:13 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47321/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 12:13 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, Jonathan 
> Hurley, and Nate Cole.
> 
> 
> Bugs: AMBARI-16639
>     https://issues.apache.org/jira/browse/AMBARI-16639
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently Ambari only takes a base url and creates a HDP file.
> 
> In addition to this, if ambari can take a repo url and download it, we will
> have the flexibility of combining 2 or more repos and downloading artifacts
> from multiple repositories.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestRepositoryResource.py 
> a69b57b 
>   ambari-common/src/main/python/resource_management/core/base.py 1500e1f 
>   
> ambari-common/src/main/python/resource_management/libraries/providers/repository.py
>  f476e29 
>   
> ambari-common/src/main/python/resource_management/libraries/resources/repository.py
>  2484d67 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  77f2ede 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  bb58670 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  5e51f5f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  7884d02 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryRequest.java
>  84929bf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RepositoryResponse.java
>  30bd0db 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryResourceProvider.java
>  3b5b0a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RepositoryVersionResourceProvider.java
>  57fb115 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/RepositoryHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RepositoryEntity.java
>  49d53a9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackContext.java 
> da7f021 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
> 8a352bd 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 6129ec0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryDistributionType.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java
>  29776ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  fc2bab1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/RepositoryXml.java
>  69eb39d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/RepositoryVersionHelper.java
>  50d6028 
>   ambari-server/src/main/resources/custom_actions/scripts/install_packages.py 
> 3133984 
>   ambari-server/src/main/resources/custom_actions/scripts/update_repo.py 
> 9f2107d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/repo_initialization.py
>  a35dce7 
>   ambari-server/src/main/resources/version_definition.xsd b6360ee 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/AmbariMetaInfoTest.java
>  e5bb7ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/KerberosServiceMetaInfoTest.java
>  befd594 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerCommonServicesTest.java
>  6f3cf78 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
>  dda1e7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerTest.java
>  8e9f81a 
>   ambari-server/src/test/python/custom_actions/TestInstallPackages.py 77e3bee 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-INSTALL/test_before_install.py
>  082d200 
> 
> Diff: https://reviews.apache.org/r/47321/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to