----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47252/#review133160 -----------------------------------------------------------
Ship it! Ship It! - Matt On May 12, 2016, 2:26 p.m., Goutam Tadi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47252/ > ----------------------------------------------------------- > > (Updated May 12, 2016, 2:26 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, jun aoki, > Lav Jain, and Matt. > > > Bugs: AMBARI-16461 > https://issues.apache.org/jira/browse/AMBARI-16461 > > > Repository: ambari > > > Description > ------- > > PXF Agents Live Widget on Dashboard needs custom widget to display only > single threshold i.e., Green/Red only > > > Diffs > ----- > > ambari-web/app/assets/test/tests.js eb2edf1 > ambari-web/app/messages.js 910bed7 > ambari-web/app/mixins.js cf8cef6 > ambari-web/app/mixins/main/dashboard/widgets/editable_with_limit.js 97b6330 > ambari-web/app/mixins/main/dashboard/widgets/single_numeric_threshold.js > PRE-CREATION > ambari-web/app/styles/modal_popups.less 5e89dbc > > ambari-web/app/templates/main/dashboard/edit_widget_popup_single_threshold.hbs > PRE-CREATION > ambari-web/app/views.js 127a996 > ambari-web/app/views/main/dashboard/widgets.js 38181c0 > ambari-web/app/views/main/dashboard/widgets/pxf_live.js 75f5886 > ambari-web/app/views/main/dashboard/widgets/text_widget_single_threshold.js > PRE-CREATION > ambari-web/test/aliases/computed/gtProperties.js f3f1def > > ambari-web/test/views/main/dashboard/widgets/text_widget_single_threshold_test.js > PRE-CREATION > > Diff: https://reviews.apache.org/r/47252/diff/ > > > Testing > ------- > > Yes, All tests passed. Test was already in place. > > > Thanks, > > Goutam Tadi > >