> On May 14, 2016, 12:20 a.m., Sumit Mohanty wrote:
> > You can add the test later but can you add the JIRA ID to the review 
> > request?
> 
> Sumit Mohanty wrote:
>     +1. Did not realize that JIRA is inaccessible. Once you have a JIRA 
> update the review and commit it.

Updated JIRA.


- Swapan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47377/#review133235
-----------------------------------------------------------


On May 14, 2016, 12:13 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47377/
> -----------------------------------------------------------
> 
> (Updated May 14, 2016, 12:13 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Sumit Mohanty.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> LLAP start/restart, after creating LLAP package relies on output that is 
> being generated in order to figure out the package name created. Typically 
> looks for line :
> 
> ----------
> Prepared llap-slider<date....>/run.sh for running LLAP on Slider
> ----------
> ----------
> 
> However, it doesn't handle parsing multi-line outputs (example):
> 
> ----------
> # #### #### ##### ### ####
> ### #### ###### #### #### #### ##### ### ## ### ####
> Prepared llap-slider2016-05-13_23-13-07/run.sh for running LLAP on Slider
> ----------
> ----------
> 
> **Resolution** : Fixed the code for parsing lines while looking for output 
> line.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  e94b22e 
> 
> Diff: https://reviews.apache.org/r/47377/diff/
> 
> 
> Testing
> -------
> 
> Yes. 
> 
> Pythn UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to