-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47175/
-----------------------------------------------------------

(Updated May 14, 2016, 5:59 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Ashwin Rajeev.


Changes
-------

fixed all the review comments


Bugs: AMBARI-16422
    https://issues.apache.org/jira/browse/AMBARI-16422


Repository: ambari


Description
-------

Earliar : UI should show validation error cue to the user for fields like 
column names and table name if illegal names are present.

In this Patch : added new component for UI validation of text fields through 
regex. It will show red border around invalid values.


Diffs (updated)
-----

  contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/file-upload.js 
1bd8eee 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/adapters/upload-table.js 
ef4df43 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/validated-text-field.js
 PRE-CREATION 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 d883743 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
b3630c1 
  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss ec4f201 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/validated-text-field.hbs
 PRE-CREATION 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 b7d9011 

Diff: https://reviews.apache.org/r/47175/diff/


Testing
-------

Manual testing done.


Thanks,

Nitiraj Rathore

Reply via email to