-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47417/#review133378
-----------------------------------------------------------




ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
 (line 32)
<https://reviews.apache.org/r/47417/#comment197727>

    I think this should be os-depend. Otherwise you'll get a problem on Ubuntu.


- Andrew Onischuk


On May 16, 2016, 4 p.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47417/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 4 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-16683
>     https://issues.apache.org/jira/browse/AMBARI-16683
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As i understood(according to discussion with Andrew O) we had some jira for 
> '*' to hdp version replacement in all packages. But here it was not replaced:
> {code}
> def get_lzo_packages(stack_version_unformatted):
>   lzo_packages = []
>  
>   if OSCheck.is_redhat_family() or OSCheck.is_suse_family():
>     lzo_packages += ["lzo", "hadoop-lzo-native"]
>   elif OSCheck.is_ubuntu_family():
>     lzo_packages += ["liblzo2-2"]
> 
>   if stack_version_unformatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_unformatted):
>     lzo_packages += ["hadooplzo_*"]
>   else:
>     lzo_packages += ["hadoop-lzo"]
> 
>   return lzo_packages
> {code}
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py
>  e189d62 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/install_params.py
>  fe488c3 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  784da9c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  75924c5 
> 
> Diff: https://reviews.apache.org/r/47417/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to