-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47018/
-----------------------------------------------------------
(Updated May 18, 2016, 8:11 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and
Sumit Mohanty.
Changes
-------
As of now, a bit stuck trying to write correct path finding at
ServicePropertiesTest .
Bugs: AMBARI-16272
https://issues.apache.org/jira/browse/AMBARI-16272
Repository: ambari
Description (updated)
-------
Today, "ambari-server upgrade" will automatically add stack configs.
However, it also causes problems when default properties or properties with
default value such as "localhost" end up being added.
This led to many bugs. E.g., cluster with NameNode HA shouldn't automatically
add dfs.namenode.secondary.http-address
This logic today will even add new config types. E.g., add ranger-env even
though Ranger is not installed. If the customer then upgrades the stack from
HDP 2.2 to 2.3, and then adds Ranger, they can get the wrong configs.
If we change this behavior, it's good to do so in a major release such as 2.4
We add required xml tags/attributes to properties:
<property>
<name>prop_name</name>
<value>prop_val</value>
<on-ambari-upgrade add="false" change="true" delete="true"/>
<on-stack-upgrade add="true" change="true" delete="false"/>
</property>
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
fb3ae69
ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java
8a352bd
ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
854dd0b
ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java
34b3ba1
ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
2e857ed
ambari-server/src/main/resources/property-schema.xsd PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
a4a3108
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
8f53f6a
ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
b11c5d8
ambari-server/src/test/java/org/apache/ambari/server/state/ServicePropertiesTest.java
PRE-CREATION
ambari-server/src/test/resources/propertiesFile.xsd PRE-CREATION
script.sh PRE-CREATION
Diff: https://reviews.apache.org/r/47018/diff/
Testing
-------
patch preview for now. Feedback is welcome
Thanks,
Dmitro Lisnichenko
