-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47517/#review133821
-----------------------------------------------------------


Ship it!




Ship It!

- Richard Zang


On May 18, 2016, 6:10 a.m., Zhe (Joe) Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47517/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 6:10 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Richard Zang, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16724
>     https://issues.apache.org/jira/browse/AMBARI-16724
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> METRIC alert types have a connection timeout in their definition but that 
> value is not exposed in the Ambari Web UI (like WEB alerts are).
>      "uri" : {
>         "http" : "{{ams-hbase-site/hbase.master.info.port}}",
>         "default_port" : 61310.0,
>         "connection_timeout" : 5.0
>       }
>  
> Include exposing the Connection Timeout critical threshold in Ambari Web for 
> METRIC alert types.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
> 617f7cc 
>   
> ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js
>  f3cf28c 
> 
> Diff: https://reviews.apache.org/r/47517/diff/
> 
> 
> Testing
> -------
> 
> Modified unit test.
> Local ambari-web test passed.
> 27819 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Reply via email to