> On May 18, 2016, 6:23 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/ambari_commons/str_utils.py, line 85
> > <https://reviews.apache.org/r/47535/diff/1/?file=1386718#file1386718line85>
> >
> >     Deoes the last fragment also need a newline?

I remove new lines at the end of every fragment. We don't them at the end of 
fragment.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47535/#review133784
-----------------------------------------------------------


On May 18, 2016, 1:37 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47535/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 1:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16732
>     https://issues.apache.org/jira/browse/AMBARI-16732
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
>   ambari-common/src/main/python/ambari_commons/str_utils.py 83fc29d 
> 
> Diff: https://reviews.apache.org/r/47535/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to