-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review133940
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
 (lines 101 - 103)
<https://reviews.apache.org/r/47531/#comment198601>

    What about any endpoint that takes host names embedded in json? Is that 
covered here?
    
    A fundamental change like this requires several unit tests covering 
QueryParser and predicate processors.  Also add tests for the Request endpoint 
that take hostnames in the body (as opposed to the URL).



ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 (line 61)
<https://reviews.apache.org/r/47531/#comment198602>

    What exceptions are you expecting here?  You're already null checking a 
bunch of stuff.  A TODO like this should be taken care of in this patch.


- Nate Cole


On May 18, 2016, 6 a.m., Vitalyi Brodetskyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 6 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Reply via email to