----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47545/#review133948 -----------------------------------------------------------
Ship it! This looks good, but you should probably test an upgrade scenario where Ambari version 2.2.2 with Atlas (from HDP 2.5) is installed and then upgraded to Ambari 2.4.0. It may be the case that this is not a possible path, I forget which versions of HDP are avaialbe before Ambari 2.4.0. - Robert Levas On May 19, 2016, 6:36 a.m., Tom Beerbower wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47545/ > ----------------------------------------------------------- > > (Updated May 19, 2016, 6:36 a.m.) > > > Review request for Ambari, Erik Bergenholtz, John Speidel, and Robert Levas. > > > Bugs: AMBARI-16730 > https://issues.apache.org/jira/browse/AMBARI-16730 > > > Repository: ambari > > > Description > ------- > > As part of ATLAS-713, the following changes are required in atlas > configuration that is set by Ambari: > > 1 atlas.lineage.hive.table.schema.query.Table renamed to > atlas.lineage.schema.query.Table > 2 atlas.lineage.hive.table.schema.query.hive_table renamed to > atlas.lineage.schema.query.hive_table > 3 delete unused lineage configs > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml > 2dab35a > > Diff: https://reviews.apache.org/r/47545/diff/ > > > Testing > ------- > > manual test Atlas install > > mvn clean test > > > Thanks, > > Tom Beerbower > >