-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47596/#review133991
-----------------------------------------------------------




ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 433)
<https://reviews.apache.org/r/47596/#comment198657>

    I think its better to introduce a variable here through which the default 
value of this property can be linked to the default value of 
```yarn.scheduler.minimum-allocation-mb``` so it doesn't has to be changed in 
two places if the default value changes.
    
    As an example look at ```{{storm_thrift_transport}}``` in storm-site.xml 
and storm's params_linux.py


- Sebastian Toader


On May 19, 2016, 6:55 p.m., Daniel Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47596/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 6:55 p.m.)
> 
> 
> Review request for Ambari, Laszlo Puskas, Oliver Szabo, Sandor Magyari, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-16776
>     https://issues.apache.org/jira/browse/AMBARI-16776
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Default value of hive.llap.daemon.yarn.container.mb is not aligned to 
> yarn.scheduler.minimum-allocation-mb
> If the former one is less than the latter one, then hive server interactive 
> wont start. So the default values must be in a proper relation.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  db5f616 
> 
> Diff: https://reviews.apache.org/r/47596/diff/
> 
> 
> Testing
> -------
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 2:15.746s
> [INFO] Finished at: Thu May 19 18:52:43 CEST 2016
> [INFO] Final Memory: 58M/1120M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Daniel Gergely
> 
>

Reply via email to