-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/#review133977
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 74)
<https://reviews.apache.org/r/47580/#comment198648>

    I would check only for presence of pxf-hbase.jar string, in case users edit 
the content with extra information



ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 84)
<https://reviews.apache.org/r/47580/#comment198659>

    here as well, just check for the jar



ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
(line 86)
<https://reviews.apache.org/r/47580/#comment198660>

    pxf-hbase.jar -- h is missing


- Alexander Denissov


On May 19, 2016, 6:11 a.m., Matt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47580/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 6:11 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16752
>     https://issues.apache.org/jira/browse/AMBARI-16752
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> In service install wizard, pxf-hbase.jar should be added to the 
> HBASE_CLASSPATH (recommendation and validation)
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
> e2510eb 
>   ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47580/diff/
> 
> 
> Testing
> -------
> 
> Manually Tested.
> 
> Unit tests added.
> 
> Hadoop QA:
> ```
> +1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12804840/AMBARI-16752-trunk-orig.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 1 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6889//console
> This message is automatically generated.
> ```
> 
> 
> Thanks,
> 
> Matt
> 
>

Reply via email to