-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47580/
-----------------------------------------------------------

(Updated May 19, 2016, 11:55 a.m.)


Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-16752
    https://issues.apache.org/jira/browse/AMBARI-16752


Repository: ambari


Description
-------

In service install wizard, pxf-hbase.jar should be added to the HBASE_CLASSPATH 
(recommendation and validation)


Diffs (updated)
-----

  ambari-admin/src/main/resources/ui/admin-web/app/index.html 9344f15 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
 5420ae5 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
3ed2687 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/DeregisterClusterModal.js
 174c0d6 
  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
 1c5f588 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 2481d59 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/modals/deregisterClusterModal.html
 e6c67ca 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
 8979cba 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/list.html 
7f525e8 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/modals/changePassword.html
 55611a0 
  ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 87d9483 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
 260f018 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 0fb017d 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 
0dcbea8 
  ambari-server/conf/unix/ambari.properties 9f1692e 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 f5e8f39 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 9c2db1c 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 b60592d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 36be39e 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
 6f2a134 
  ambari-server/src/main/python/ambari_server/serverSetup.py f01465d 
  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 119f2c7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 b9b49e9 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 abb47e5 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 9094f7f 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 e3aff9d 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 abb8469 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 a1ffc5e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 716b612 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 f285853 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 81a4e3e 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 7a68a32 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 3a9f51e 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 5d454de 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 d4eb6b9 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 dd3a692 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 2f091a5 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 b76bc89 
  ambari-server/src/main/resources/common-services/PXF/3.0.0/service_advisor.py 
e2510eb 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 d4418e0 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
 3dc4914 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 0a39219 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 03c1258 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 c154a16 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
 bac836c 
  ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
a040f8a 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 87dfaf1 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 caafd55 
  ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json 
e739e3a 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 e156537 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
 6ea7f82 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 6ed4146 
  ambari-server/src/main/resources/scripts/takeover_config_merge.py 075f99f 
  ambari-server/src/main/resources/scripts/takeover_files_mapping.json 69b4085 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 53c1369 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 1a7ff67 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
 a6e5501 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java
 f78024f 
  ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 61de03a 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py 4e2a9cd 
  ambari-server/src/test/python/stacks/2.3/PXF/test_service_advisor.py 
PRE-CREATION 
  ambari-web/app/controllers.js 2537f62 
  ambari-web/app/controllers/global/errors_handler_controller.js 52feea3 
  ambari-web/app/controllers/installer.js 7d65ddc 
  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 2feeb7f 
  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
9b48b35 
  ambari-web/app/controllers/main/service/add_controller.js c8763c7 
  ambari-web/app/controllers/main/service/item.js 77584ba 
  ambari-web/app/mappers/configs/stack_config_properties_mapper.js 2c8959d 
  ambari-web/app/styles/widgets.less 263736d 
  ambari-web/app/templates/common/configs/widgets/combo_config_widget.hbs 
a338315 
  ambari-web/app/views/common/configs/widgets/textfield_config_widget_view.js 
1bb97fa 
  ambari-web/app/views/common/controls_view.js 4e90ead 
  ambari-web/app/views/main/admin/kerberos/step1_view.js faf9caf 
  ambari-web/app/views/main/alert_definitions_view.js 82de557 
  ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
a90fa72 
  
ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 
2ea42f7 
  ambari-web/test/controllers/main/service/add_controller_test.js 3939632 
  ambari-web/test/controllers/main/service/item_test.js 0830d63 
  ambari-web/test/mappers/configs/stack_config_properties_mapper_test.js 
196e682 
  contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss be6d9ac 
  contrib/views/tez/src/main/resources/ui/ambari-scripts/init-view.js 8bbcf01 
  contrib/views/utils/pom.xml f2b7013 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/ValidatorUtils.java
 f5f8bd9 
  
contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 9edf9d7 

Diff: https://reviews.apache.org/r/47580/diff/


Testing (updated)
-------

Manually Tested.

Unit tests added.

```
test_createComponentLayoutRecommendations_hawq_1_Host 
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_createComponentLayoutRecommendations_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSTANDBY is recommended on a 3-node cluster ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT does not get recommended during Add Service Wizard, when 
HAWQ has already been installed ... ok
test_createComponentLayoutRecommendations_hawqsegment_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Add Service Wizard, 
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_hawqsegment_cluster_install 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that HAWQSEGMENT gets recommended correctly during Cluster Install Wizard, 
when HAWQ is selected for installation ... ok
test_createComponentLayoutRecommendations_no_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_already_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF does not get recommended during Add Service Wizard, when PXF has 
already been installed ... ok
test_createComponentLayoutRecommendations_pxf_add_service_wizard_to_be_installed
 (test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Add Service Wizard, when PXF is 
selected for installation ... ok
test_createComponentLayoutRecommendations_pxf_cluster_install 
(test_stack_advisor.TestHDP23StackAdvisor)
Test that PXF gets recommended correctly during Cluster Install Wizard, when 
PXF is selected for installation ... ok
test_getComponentLayoutValidations_hawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test layout validations for HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_hawqsegment_not_co_located_with_datanode 
(test_stack_advisor.TestHDP23StackAdvisor)
Test validation warning for HAWQ segment not colocated with DATANODE ... ok
test_getComponentLayoutValidations_nohawq_3_Hosts 
(test_stack_advisor.TestHDP23StackAdvisor)
Test no failures when there are no HAWQ components on a 3-node cluster ... ok
test_getComponentLayoutValidations_pxf_co_located_with_nn_and_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test NO warning is generated when PXF is co-located with NAMENODE and DATANODE 
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE 
... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE ... ok
test_getComponentLayoutValidations_pxf_not_co_located_with_nn_or_dn 
(test_stack_advisor.TestHDP23StackAdvisor)
Test warning is generated when PXF is not co-located with NAMENODE or DATANODE 
... ok
test_getComponentLayoutValidations_sparkts_no_hive 
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is not installed ... ok
test_getComponentLayoutValidations_sparkts_with_hive 
(test_stack_advisor.TestHDP23StackAdvisor)
Test SparkTS is picked when Hive is installed ... ok
test_noRiskyDictLookups (test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendFalconConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendHAWQConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_recommendHBASEConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_recommendHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_recommendHiveConfigurations_with_atlas 
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendKAFKAConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendLogsearchConfiguration (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendRangerConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendRangerKMSConfigurations 
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_recommendSqoopConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendStormConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_recommendTezConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_recommendYARNConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_validateHAWQHdfsClientConfigurations 
(test_stack_advisor.TestHDP23StackAdvisor) ... ok
test_validateHAWQSiteConfigurations (test_stack_advisor.TestHDP23StackAdvisor) 
... ok
test_validateHDFSConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok
test_validateHiveConfigurations (test_stack_advisor.TestHDP23StackAdvisor) ... 
ok

----------------------------------------------------------------------
Ran 37 tests in 1.480s

OK
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service PXF was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
ServiceAdvisor implementation for service HAWQ was loaded
test_execute (test_alerts_api_status.TestAlertsApiStatus) ... No handlers could 
be found for logger "ambari_alerts"
ok
test_get_pxf_protocol_version (test_alerts_api_status.TestAlertsApiStatus) ... 
ok
test_configure_default (test_pxf.TestPxf) ... ok
test_install_default (test_pxf.TestPxf) ... ok
test_start_default (test_pxf.TestPxf) ... ok
test_status_default (test_pxf.TestPxf) ... ok
test_stop_default (test_pxf.TestPxf) ... ok
test_getConfigurationsValidationItems 
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok
test_getServiceConfigurationRecommendations 
(test_service_advisor.TestPXF300ServiceAdvisor) ... ok

----------------------------------------------------------------------
Ran 9 tests in 0.033s

OK
SiteName: hbase-env, method: validatePXFHBaseEnvConfigurations

Site properties: {'content': '# Some hbase-env content text'}

Recommendations: {'content': '# Some hbase-env content text'}
********
```


Thanks,

Matt

Reply via email to