-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review134050
-----------------------------------------------------------


Ship it!




Ship It!

- Jayush Luniya


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
>     https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> -------
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Reply via email to