-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47621/#review134085
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 (line 97)
<https://reviews.apache.org/r/47621/#comment198730>

    convert it to a function and remove it from the exclude list. Its seems odd 
in that list as this property is not being deleted.
    
    You can add a unit test too - sample test attached to JIRA 16784


- Sumit Mohanty


On May 20, 2016, 1:50 a.m., Swapan Shridhar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47621/
> -----------------------------------------------------------
> 
> (Updated May 20, 2016, 1:50 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16784
>     https://issues.apache.org/jira/browse/AMBARI-16784
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> - As hive2/hive-site.xml only contains the new + the changed props compared 
> to hive/hive-site.xml, we merge hive/hive-site.xml and hive2/hive-site.xml 
> and store it in hive2/hive-site.xml.
> - Thus, as part of the merge, specifically for Hive2/hive-site.xml config 
> 'hive.exec.post.hooks', it gets the hook for Atlas from Hive1/hive-site.xml, 
> if Atlas is installed. As Atlas is not supported by Hive2, we need to remove 
> it.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  8e49cf0 
> 
> Diff: https://reviews.apache.org/r/47621/diff/
> 
> 
> Testing
> -------
> 
> Python UT passes.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Reply via email to