> On May 19, 2016, 4:08 p.m., Alexandr Antonenko wrote:
> > Ship It!

Hi Alexander, can you please help push the fix. Thank you.


- Sangeeta


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47599/#review133961
-----------------------------------------------------------


On May 19, 2016, 4:02 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47599/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 4:02 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-16737
>     https://issues.apache.org/jira/browse/AMBARI-16737
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Currently, when you edit alert names, on the Ambari dashboard, there is no 
> validation and you can enter characters such as \, < etc.
> You can aslo enter more than 255 characters, the UI shows no indication of 
> error and accepts more than 255 characters. However, an exception is thrown 
> on the server side because the database column only allows 255 characters. 
> The UI should restrict this. The value in the UI gets reset to what it was 
> before you added more than 255 characters since the update failed.
>  
> Added UI validation to the alert name field.
> Also set the maxLength to 255 characters.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/messages.js 74f918d 
>   ambari-web/app/styles/alerts.less 50246e6 
>   ambari-web/app/templates/main/alerts/definition_details.hbs cda1193 
>   ambari-web/app/utils/validator.js 2906749 
>   ambari-web/app/views/main/alerts/definition_details_view.js 656021c 
>   ambari-web/test/views/main/alerts/definition_details_view_test.js a98b66b 
> 
> Diff: https://reviews.apache.org/r/47599/diff/
> 
> 
> Testing
> -------
> 
> Added new test case in definition_details_view_test.js
> Also, tested manually.
> Ran ambari-web mvn test without errors.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Reply via email to