-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/#review134269
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json (line 
13)
<https://reviews.apache.org/r/47579/#comment198984>

    should be spark2-defaults?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 (line 50)
<https://reviews.apache.org/r/47579/#comment198990>

    spark2-history instead?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 (line 82)
<https://reviews.apache.org/r/47579/#comment198991>

    spark2-history instead?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 63)
<https://reviews.apache.org/r/47579/#comment198992>

    spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 66)
<https://reviews.apache.org/r/47579/#comment198993>

    spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 71)
<https://reviews.apache.org/r/47579/#comment198994>

    spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 (line 78)
<https://reviews.apache.org/r/47579/#comment198997>

    Does this need to be defined as Spark2?



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
 (line 25)
<https://reviews.apache.org/r/47579/#comment198995>

    spark2-log4j-properties



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
 (line 24)
<https://reviews.apache.org/r/47579/#comment198996>

    spark2-metrics-properties



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
 (line 26)
<https://reviews.apache.org/r/47579/#comment198998>

    Make sure metrics for Spark and Spark2 are separated out.



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 12)
<https://reviews.apache.org/r/47579/#comment198985>

    spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 14)
<https://reviews.apache.org/r/47579/#comment198986>

    spark2-defaults



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 15)
<https://reviews.apache.org/r/47579/#comment198987>

    spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 20)
<https://reviews.apache.org/r/47579/#comment198988>

    spark2-env



ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
(line 27)
<https://reviews.apache.org/r/47579/#comment198989>

    spark2-defaults


- Jayush Luniya


On May 19, 2016, 5:50 a.m., Saisai Shao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47579/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 5:50 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16753
>     https://issues.apache.org/jira/browse/AMBARI-16753
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Add Spark2 service definition for Ambari
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47579/diff/
> 
> 
> Testing
> -------
> 
> Local manual test
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Reply via email to