-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47721/#review134334
-----------------------------------------------------------


Ship it!




Ship It!

- Rohit Choudhary


On May 23, 2016, 10:21 a.m., Gaurav Nagar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47721/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 10:21 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16812
>     https://issues.apache.org/jira/browse/AMBARI-16812
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Changed cluster_handle in view instance to have cluster_id instead of 
> cluster_name.
> Made Remote cluster name editable
> 
> 
> Diffs
> -----
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/CreateViewInstanceCtrl.js
>  034b113 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/ambariViews/ViewsEditCtrl.js
>  2b1fb3b 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/remoteClusters/RemoteClustersEditCtrl.js
>  20eb552 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Cluster.js 
> 0bf73d5 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/RemoteCluster.js
>  e4826e6 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/View.js 
> dfe7ba8 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/create.html
>  051d720 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> 3a69a50 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/remoteClusters/editRemoteClusterPage.html
>  b5890bf 
>   
> ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/CreateViewInstanceCtrl.js
>  595fcc0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/ClusterNotFoundException.java
>  cd338a0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
>  413dbff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  b8ed215 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RemoteAmbariClusterDAO.java
>  72ab368 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RemoteAmbariClusterEntity.java
>  99c9f2a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ViewInstanceEntity.java
>  98bafdd 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Clusters.java 
> e660d20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java
>  f78dd95 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/RemoteAmbariClusterRegistry.java
>  38a47a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/view/ViewContextImpl.java
>  e98a4cd 
>   ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
> 6d4ef82 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 31dd8f2 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 3c4f1ca 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql f31af16 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql d1147b7 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql 
> 5a7a6a5 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 2dba3b7 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql e769e5b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UserPrivilegeResourceProviderTest.java
>  88b00ca 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProviderTest.java
>  1044570 
>   
> ambari-server/src/test/java/org/apache/ambari/server/security/authorization/AuthorizationHelperTest.java
>  9c59aab 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
>   
> ambari-views/src/main/java/org/apache/ambari/view/ViewInstanceDefinition.java 
> cea4c88 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/PropertyValidator.java
>  ae73bc0 
>   
> contrib/views/pig/src/main/java/org/apache/ambari/view/pig/PropertyValidator.java
>  d3c9866 
> 
> Diff: https://reviews.apache.org/r/47721/diff/
> 
> 
> Testing
> -------
> 
> Manually tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Reply via email to