-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47565/#review134378
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
 (line 98)
<https://reviews.apache.org/r/47565/#comment199165>

    Current delete impl do not remove host before hostcomponent but it might be 
appropriate to throw a UnChecked exception here vs a NPE if host is already 
removed. Optional for this patch since such code path is non-existent.


- Sid Wagle


On May 19, 2016, 10:04 p.m., Nahappan Somasundaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47565/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 10:04 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-16751
>     https://issues.apache.org/jira/browse/AMBARI-16751
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-16751: Refresh stale host entity reference when deleting a service
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAO.java
>  46da9dacf0e1c48249a83a167d5903f0ec100f7c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/orm/dao/HostComponentDesiredStateDAOTest.java
>  b7a0677bcdd5ced0de9fd2bfcb7f290a6f6fe648 
> 
> Diff: https://reviews.apache.org/r/47565/diff/
> 
> 
> Testing
> -------
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ....................................... SUCCESS [7.380s]
> [INFO] Apache Ambari Project POM ......................... SUCCESS [0.036s]
> [INFO] Ambari Web ........................................ SUCCESS [23.544s]
> [INFO] Ambari Views ...................................... SUCCESS [1.061s]
> [INFO] Ambari Admin View ................................. SUCCESS [21.344s]
> [INFO] ambari-metrics .................................... SUCCESS [0.602s]
> [INFO] Ambari Metrics Common ............................. SUCCESS [0.912s]
> [INFO] Ambari Metrics Hadoop Sink ........................ SUCCESS [2.140s]
> [INFO] Ambari Metrics Flume Sink ......................... SUCCESS [1.109s]
> [INFO] Ambari Metrics Kafka Sink ......................... SUCCESS [0.996s]
> [INFO] Ambari Metrics Storm Sink ......................... SUCCESS [2.969s]
> [INFO] Ambari Metrics Collector .......................... SUCCESS [10.957s]
> [INFO] Ambari Metrics Monitor ............................ SUCCESS [2.705s]
> [INFO] Ambari Metrics Grafana ............................ SUCCESS [1.289s]
> [INFO] Ambari Metrics Assembly ........................... SUCCESS [1:31.486s]
> [INFO] Ambari Server ..................................... SUCCESS [2:27.145s]
> [INFO] Ambari Functional Tests ........................... SUCCESS [1.128s]
> [INFO] Ambari Agent ...................................... SUCCESS [23.899s]
> [INFO] Ambari Client ..................................... SUCCESS [0.047s]
> [INFO] Ambari Python Client .............................. SUCCESS [0.993s]
> [INFO] Ambari Groovy Client .............................. SUCCESS [2.117s]
> [INFO] Ambari Shell ...................................... SUCCESS [0.078s]
> [INFO] Ambari Python Shell ............................... SUCCESS [0.717s]
> [INFO] Ambari Groovy Shell ............................... SUCCESS [0.841s]
> [INFO] ambari-logsearch .................................. SUCCESS [0.191s]
> [INFO] Ambari Logsearch Appender ......................... SUCCESS [0.223s]
> [INFO] Ambari Logsearch Solr Client ...................... SUCCESS [1.043s]
> [INFO] Ambari Logsearch Portal ........................... SUCCESS [5.856s]
> [INFO] Ambari Logsearch Log Feeder ....................... SUCCESS [2.262s]
> [INFO] Ambari Logsearch Assembly ......................... SUCCESS [0.119s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 5:55.888s
> [INFO] Finished at: Wed May 18 16:42:38 PDT 2016
> [INFO] Final Memory: 290M/1262M
> [INFO] 
> ------------------------------------------------------------------------
> 
> ** 2. mvn test -Dtest=HostComponentDesiredStateDAOTest -DskipPythonTests **
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m 
> -Djava.awt.headless=true
> Running org.apache.ambari.server.orm.dao.HostComponentDesiredStateDAOTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.209 sec - 
> in org.apache.ambari.server.orm.dao.HostComponentDesiredStateDAOTest
> 
> Results :
> 
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 24.701s
> [INFO] Finished at: Thu May 19 14:59:41 PDT 2016
> [INFO] Final Memory: 57M/1024M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Reply via email to