> On Май 23, 2016, 3:59 п.п., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-common/pom.xml, line 78
> > <https://reviews.apache.org/r/47730/diff/1/?file=1391654#file1391654line78>
> >
> >     This will collide due to Hadoop dependency in version 14.0.1, I faced a 
> > problem here before. Can we make this shaded ?

Do you mean use https://maven.apache.org/plugins/maven-shade-plugin ? I would 
propose to use same 14.0.1 for ambari-metrics-common


- Dmytro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47730/#review134370
-----------------------------------------------------------


On Май 23, 2016, 3:48 п.п., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47730/
> -----------------------------------------------------------
> 
> (Updated Май 23, 2016, 3:48 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Myroslav Papirkovskyy, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-16821
>     https://issues.apache.org/jira/browse/AMBARI-16821
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The TimelineMetricsCache implementation in the metrics sink side is currently 
> a ConcurrentSkipListMap. It is better to use pre built cache libraries like 
> Guava that offer more support.
> 
> 
> Diffs
> -----
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 5a388dd 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCache.java
>  0bed7d0 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsCacheTest.java
>  18d973c 
> 
> Diff: https://reviews.apache.org/r/47730/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to