-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47766/#review134571
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for contributing this fix. 

The patch looks fine to me, just a minor issue below to fix in the unit test.

I do have one small request:

Prior to merging, can you also please run a manual test to verify the following 
case:

- HDFS HA Blueprints deployment, without setting these two properties in the 
Blueprint or Cluster Creation Template

It would be helpful to verify that the automatic assignment of active/standby 
nodes still works as expected with this change in place.

Thanks!


ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
 (line 31)
<https://reviews.apache.org/r/47766/#comment199419>

    Minor issue:
    
    Can you please use explicit imports here?  In Ambari, we generally try to 
avoid * imports for classes.
    
    Thanks.


- Robert Nettleton


On May 24, 2016, 12:19 p.m., Balázs Bence Sári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47766/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 12:19 p.m.)
> 
> 
> Review request for Ambari, Daniel Gergely, Laszlo Puskas, Oliver Szabo, 
> Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16822
>     https://issues.apache.org/jira/browse/AMBARI-16822
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Host name resolution for dfs_ha_initial_namenode_active and 
> dfs_ha_initial_namenode_standby properties. Support for these two properties 
> has been added added to BluePrintProcessor. Also made sure the these 
> properties are not exported with blueprints as per the docs.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
>  1ddc4e1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessorTest.java
>  5c6aeaf 
> 
> Diff: https://reviews.apache.org/r/47766/diff/
> 
> 
> Testing
> -------
> 
> - Wrote a unit test to check host name resolution for the two properties.
> - Wrote a unit test to check that the two properties are not exported with 
> blueprints.
> - All unit tests in ambari-server passed.
> - Run a manual test to verify that the host names are resolved for the two 
> properties and the two properties are not exported with blueprints.
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Reply via email to