-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47769/#review134611
-----------------------------------------------------------


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py
 (line 22)
<https://reviews.apache.org/r/47769/#comment199454>

    Should we change the file name since it is no longer just for datanode?



ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
 (line 53)
<https://reviews.apache.org/r/47769/#comment199455>

    Please add some code comments for what this does.



ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 (line 181)
<https://reviews.apache.org/r/47769/#comment199453>

    Please add comments for what this does.


- Alejandro Fernandez


On May 24, 2016, 11:29 a.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47769/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 11:29 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Srimanth 
> Gunturi.
> 
> 
> Bugs: AMBARI-16839
>     https://issues.apache.org/jira/browse/AMBARI-16839
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The part 1 of this jira will only contain the bellow functionality:
> - to make yarn dirs behave the same as dfs_data_dirs. (prevent creating on / 
> and other logics for dfs_data_dirs)
> - don't fail on chmod of not existent dirs.
> 
> The cluster-env properties we discussed will be handled in the jira.
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py 
> 1f16668 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py
>  571c089 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_datanode_unmounted_data_dir.py
>  606633e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
>  2ca2e1e 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
>  9094f7f 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  e156537 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  6ed4146 
>   
> ambari-server/src/test/python/stacks/2.0.6/HDFS/test_alert_datanode_unmounted_data_dir.py
>  16400b1 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_datanode.py 90c12ca 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 61de03a 
> 
> Diff: https://reviews.apache.org/r/47769/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Reply via email to