> On 五月 24, 2016, 1:23 p.m., Tom Beerbower wrote: > > The fix looks okay to me. How did you test it? Could you please complete > > the "testing done" section of the review?
that's done, thanks. That is my first time commit for Ambari, Could you tell me what to do to close my jira issue. - chen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47773/#review134576 ----------------------------------------------------------- On 五月 25, 2016, 12:10 a.m., chen jian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47773/ > ----------------------------------------------------------- > > (Updated 五月 25, 2016, 12:10 a.m.) > > > Review request for Ambari, Alexandr Antonenko, Robert Nettleton, and Tom > Beerbower. > > > Bugs: AMBARI-16733 > https://issues.apache.org/jira/browse/AMBARI-16733 > > > Repository: ambari > > > Description > ------- > > one very careless mistake for ambari agent cancel logic > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/ActionQueue.py 19bd18f > > Diff: https://reviews.apache.org/r/47773/diff/ > > > Testing > ------- > > done. > > > Thanks, > > chen jian > >
