----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134692 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py (line 207) <https://reviews.apache.org/r/47802/#comment199567> if user manually puts a value for this field, will we override it with our recommendations every time they navigate to the config page ? ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json (line 201) <https://reviews.apache.org/r/47802/#comment199566> can this be a slider between 0 ad 100 ? Should we also have validation that the value is within that range if user manually enters the number ? - Alexander Denissov On May 25, 2016, 12:17 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47802/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 12:17 a.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16827 > https://issues.apache.org/jira/browse/AMBARI-16827 > > > Repository: ambari > > > Description > ------- > > expose vm.overcommit_ratio on hawq-sysctl-env > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > c51b012 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 836144c > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > e4d1c45 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 53c5574 > > Diff: https://reviews.apache.org/r/47802/diff/ > > > Testing > ------- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >
