-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134917
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
 (line 325)
<https://reviews.apache.org/r/47802/#comment199883>

    Might have to change this if you are changing the default to 2 on line 320



ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
(line 336)
<https://reviews.apache.org/r/47802/#comment199881>

    Is this an override?
    I don't see this function being called anywhere...



ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py (line 210)
<https://reviews.apache.org/r/47802/#comment199884>

    This required?



ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py (line 216)
<https://reviews.apache.org/r/47802/#comment199885>

    This required?


- Matt


On May 25, 2016, 9:54 p.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 9:54 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
>     https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  5be3848 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> -------
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Reply via email to