-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47705/#review134923
-----------------------------------------------------------



Could anyone give me any comments?

- Masahiro Tanaka


On May 22, 2016, 10:01 p.m., Masahiro Tanaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47705/
> -----------------------------------------------------------
> 
> (Updated May 22, 2016, 10:01 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16731
>     https://issues.apache.org/jira/browse/AMBARI-16731
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> reqSignCrt method opens CSR file with open function but that doesn't close it.
> And, loadSrvrCrt method opens a file but this is unclosed too.
> They waste resources and may cause a problem
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/security.py 779b85c 
> 
> Diff: https://reviews.apache.org/r/47705/diff/
> 
> 
> Testing
> -------
> 
> mvn -fae clean install
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Reply via email to