> On May 26, 2016, 5:05 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py,
> >  line 340
> > <https://reviews.apache.org/r/47802/diff/2/?file=1395185#file1395185line340>
> >
> >     Is this an override?
> >     I don't see this function being called anywhere...

will remove this for now.
to not display some of the properties based on a config value we need to set 
the attribute so added this function earlier.


> On May 26, 2016, 5:05 a.m., Matt wrote:
> > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py, line 
> > 210
> > <https://reviews.apache.org/r/47802/diff/2/?file=1395187#file1395187line210>
> >
> >     This required?

yes. vm.overcommit_ratio = '' indicates that this is the first time when the 
configuration is loaded i.e while coming on the configuration page the first 
time while adding a service. 
if this is '', we recommend vm.overcommit_memory and set vm.overcommit_ratio = 
50, so now on the screen both the values vm.overcommit_memory and 
vm.overcommit_ratio will be there. So if now on this page, you change ratio or 
memory, the values entered by the user are taken for calculations.

However, there is one issue which needs to be fixed yet. For configuration with 
value-list, the recommendation are given by the stack advisor, but the UI loads 
the value which is the default for it in the xml file, ex vm.overcommit_memory.


> On May 26, 2016, 5:05 a.m., Matt wrote:
> > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py, line 
> > 216
> > <https://reviews.apache.org/r/47802/diff/2/?file=1395187#file1395187line216>
> >
> >     This required?

yes.


- bhuvnesh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47802/#review134917
-----------------------------------------------------------


On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47802/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 4:54 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, Lav Jain, and Matt.
> 
> 
> Bugs: AMBARI-16827
>     https://issues.apache.org/jira/browse/AMBARI-16827
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> expose vm.overcommit_ratio on hawq-sysctl-env
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml
>  5be3848 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml
>  c51b012 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  836144c 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json 
> e4d1c45 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 53c5574 
> 
> Diff: https://reviews.apache.org/r/47802/diff/
> 
> 
> Testing
> -------
> 
> yes. test case added.
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Reply via email to