> On May 25, 2016, 3:38 a.m., Alexander Denissov wrote: > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json, > > line 201 > > <https://reviews.apache.org/r/47802/diff/1/?file=1392948#file1392948line201> > > > > can this be a slider between 0 ad 100 ? Should we also have validation > > that the value is within that range if user manually enters the number ? > > bhuvnesh chaudhary wrote: > Based on some of the articles i read, it suggested that the value of this > parameter can be greater than 100 and was not able to find what is the > maximum, so kept it as text-field > > Alexander Denissov wrote: > maybe at least specify min value as 0 for the property in the .xml file ?
ok, will add and test. - bhuvnesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47802/#review134692 ----------------------------------------------------------- On May 26, 2016, 4:54 a.m., bhuvnesh chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47802/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 4:54 a.m.) > > > Review request for Ambari, Alexander Denissov, Lav Jain, and Matt. > > > Bugs: AMBARI-16827 > https://issues.apache.org/jira/browse/AMBARI-16827 > > > Repository: ambari > > > Description > ------- > > expose vm.overcommit_ratio on hawq-sysctl-env > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-site.xml > 5be3848 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/configuration/hawq-sysctl-env.xml > c51b012 > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py > 836144c > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/themes/theme.json > e4d1c45 > ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py > 53c5574 > > Diff: https://reviews.apache.org/r/47802/diff/ > > > Testing > ------- > > yes. test case added. > > > Thanks, > > bhuvnesh chaudhary > >