> On May 24, 2016, 1:08 p.m., Nitiraj Rathore wrote:
> > contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js,
> >  line 135
> > <https://reviews.apache.org/r/47738/diff/1/?file=1391797#file1391797line135>
> >
> >     Instead of Array.map() you should use Array.filter().
> >     Array.map will leave 'undefined' values in the new array. while 
> > Array.filter() will remove the unwanted elements.

Correct, implemented this change in new upload.


- Pallav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47738/#review134574
-----------------------------------------------------------


On May 23, 2016, 6:44 p.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47738/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 6:44 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj 
> Rathore.
> 
> 
> Bugs: AMBARI-16825
>     https://issues.apache.org/jira/browse/AMBARI-16825
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Removed unlickable links.
> 
> 
> Diffs
> -----
> 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index/history-query/explain.js
>  20092e2 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/styles/app.scss 
> be6d9ac 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/components/tree-view.hbs
>  cb83ec3 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/templates/index/history-query/explain.hbs
>  3f8810f 
> 
> Diff: https://reviews.apache.org/r/47738/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Reply via email to