> On May 25, 2016, 10:02 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java, > > line 287 > > <https://reviews.apache.org/r/47867/diff/1/?file=1395048#file1395048line287> > > > > Nitpicking here, but should check size > 1
:) I had noticed this check was in an odd spot, so had only moved it. But you're right, a check of >1 is appropriate. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47867/#review134902 ----------------------------------------------------------- On May 25, 2016, 8:54 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47867/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 8:54 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. > > > Bugs: AMBARI-16889 > https://issues.apache.org/jira/browse/AMBARI-16889 > > > Repository: ambari > > > Description > ------- > > Throw an error when POSTing to /api/v1/clusters/<cluster>/stack_versions > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java > 05ee6c9 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > 4a214e1 > ambari-server/src/main/resources/version_definition.xsd b6360ee > > ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java > 8347a7b > > Diff: https://reviews.apache.org/r/47867/diff/ > > > Testing > ------- > > Manual. Automated pending > > > Thanks, > > Nate Cole > >
