> On May 25, 2016, 7:30 p.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py,
> >  line 150
> > <https://reviews.apache.org/r/47785/diff/2/?file=1394010#file1394010line150>
> >
> >     Just wanted to make sure if this always be true?
> 
> Nate Cole wrote:
>     I think this assumption should be ok - we are already doing the symlink 
> magic to point to the right spot.
> 
> Tom Beerbower wrote:
>     Thanks for the review Srimanth and Nate.
>     
>     Looking in the HBase status_params.py, I see this ...
>     
>         hbase_conf_dir = "/etc/hbase/conf"
>         if stack_version_formatted and 
> check_stack_feature(StackFeature.ROLLING_UPGRADE, stack_version_formatted):
>           hbase_conf_dir = 
> format("{stack_root}/current/{component_directory}/conf")
>     
>     Do, I need to add the same logic?

That's probably outside the scope of this fix, but that code you pointed out is 
used such that when doing an upgrade, you are looking at the right place for 
configs.  I don't fully understand the relationship between Atlas and HBase (is 
the dependence only on the client?), so that can probably be a different patch.


- Nate


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47785/#review134876
-----------------------------------------------------------


On May 25, 2016, 6:06 p.m., Tom Beerbower wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47785/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 6:06 p.m.)
> 
> 
> Review request for Ambari, John Speidel, Nate Cole, and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16853 and ATLAS-823
>     https://issues.apache.org/jira/browse/AMBARI-16853
>     https://issues.apache.org/jira/browse/ATLAS-823
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> To support this, add dependency from Atlas to LogSearch SOLR.  Also remove 
> references to embedded SOLR and embedded HBase.
> 
> Use solr_cloud_util to create indexes for Atlas install.
> 
> See AMBARI-15865.
> See Atlas-823.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml
>  bf0467e 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml
>  dd4b3e2 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml
>  3c4826d 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml 
> f4115f7 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py
>  6b045ca 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py
>  e305138 
>   
> ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
>  f172b79 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
>  0631b7d 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml
>  2a5f777 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml 
> 15daeea 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> af812fe 
>   ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
> 98fc678 
>   ambari-server/src/test/python/stacks/2.3/configs/default.json c8b418b 
>   ambari-server/src/test/python/stacks/2.3/configs/secure.json 7ebcedf 
>   ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 9d0f00c 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> 51c0d0c 
>   ambari-server/src/test/python/stacks/2.5/configs/default.json e4a97f6 
> 
> Diff: https://reviews.apache.org/r/47785/diff/
> 
> 
> Testing
> -------
> 
> Manual test of Atlas install.
> 
> Updated unit tests.
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Tom Beerbower
> 
>

Reply via email to