-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47913/#review135051
-----------------------------------------------------------


Ship it!





contrib/version-builder/example.sh (lines 39 - 40)
<https://reviews.apache.org/r/47913/#comment200030>

    Maybe explain that it must be before, otherwise the XSD validation will 
fail.


- Jonathan Hurley


On May 26, 2016, 3:46 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47913/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 3:46 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-16909
>     https://issues.apache.org/jira/browse/AMBARI-16909
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The {{package-version}} element should belong with the {{os}} element such 
> that we can send that information to agents effectively when multiple OS are 
> defined in the XML.  This will allow us to use specific build numbers when 
> installing packages without using wildcards.
> 
> This patch only covers builder + XSD.  Ambari code to send this data to 
> agents is another JIRA.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/version_definition.xsd 8c20c06 
>   contrib/version-builder/example.py dd719bc 
>   contrib/version-builder/example.sh ce60318 
>   contrib/version-builder/version_builder.py 2e3fc7f 
> 
> Diff: https://reviews.apache.org/r/47913/diff/
> 
> 
> Testing
> -------
> 
> No new tests as majority of testing is in {{contrib}}.  Automated testing 
> enough to verify existing XML still worked:
> 
> mvn test -Dtest=VersionDefinition*
> 
> -------------------------------------------------------
>  T E S T S
> -------------------------------------------------------
> Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
> Running 
> org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
> Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 29.244 sec - 
> in 
> org.apache.ambari.server.controller.internal.VersionDefinitionResourceProviderTest
> Picked up JAVA_TOOL_OPTIONS: -Xmx2048m -XX:MaxPermSize=128m
> Running org.apache.ambari.server.state.repository.VersionDefinitionTest
> Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.595 sec - 
> in org.apache.ambari.server.state.repository.VersionDefinitionTest
> 
> Results :
> 
> Tests run: 13, Failures: 0, Errors: 0, Skipped: 0
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Reply via email to