-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47920/#review135128
-----------------------------------------------------------


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 26, 2016, 10:36 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47920/
> -----------------------------------------------------------
> 
> (Updated May 26, 2016, 10:36 p.m.)
> 
> 
> Review request for Ambari, Zhe (Joe) Wang, Richard Zang, Xi Wang, and Yusaku 
> Sako.
> 
> 
> Bugs: AMBARI-16911
>     https://issues.apache.org/jira/browse/AMBARI-16911
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Change the primary button text from "save" to "select" as at this point we 
> are not saving the selection. It gets saved when "save configurations" 
> happens for Hive service.
> 2. We can show close/cancel button but on clicking those buttons we need to 
> show another popup with the warning message that "Interactive query cannot be 
> enabled without "Not selecting HiveServer2 Interactive host will disable 
> interactive query". If user acknowledge that, we need to dismiss this warning 
> popup, "Select hosts" popup and revert the changed config "Enable interactive 
> query" from "yes" to "no". As I said "Enabling interactive query and 
> selecting HSI host are atomic operations." If we are rolling back from 
> selecting HSI host then we need to disable interactive query as well.
> 3. Change HiveServer2 endpoint label to HiveServer2 JDBC URL label
> 4. Change class span-6 to span-12 for summary info section of Hive Service
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/main/service/info/summary.js eb0e850 
>   ambari-web/app/controllers/wizard/step7/assign_master_controller.js 7a610da 
>   ambari-web/app/messages.js 8763721 
>   ambari-web/app/templates/common/assign_master_components.hbs 893d1e6 
>   ambari-web/app/views/common/assign_master_components_view.js 95ba766 
>   ambari-web/app/views/main/service/services/hive.js d306433 
>   ambari-web/app/views/wizard/step7/assign_master_view.js d6a456f 
> 
> Diff: https://reviews.apache.org/r/47920/diff/
> 
> 
> Testing
> -------
> 
> Verified that the patch addresses the issue manually. attached snpashot of 
> the changes to the Jira.
> 
> Verified that the patch passes all ambari-web unit tests:
> 27856 tests complete (28 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to