-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47783/
-----------------------------------------------------------
(Updated May 27, 2016, 9:52 a.m.)
Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, and Nate
Cole.
Changes
-------
System actions have been updated to include a comma-delimited set of
permissions in their definitions. This permissions are evaluated on startup and
then referenced when Request resources are created to help determine the
authenticated user's authorization to perform the requested operation
Bugs: AMBARI-16851
https://issues.apache.org/jira/browse/AMBARI-16851
Repository: ambari
Description
-------
Cluster operator and the cluster admin must be allowed to add/delete hosts but
install of agents using /bootstrap fails with 403
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RequestResourceProvider.java
5b318af
ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinition.java
1f189a3
ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionManager.java
97aa8a0
ambari-server/src/main/java/org/apache/ambari/server/customactions/ActionDefinitionSpec.java
2dfa1f2
ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java
5c74f07
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
0deba5d
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 2c2d743
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql ee87cc5
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql edc46f7
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 6f38ec8
ambari-server/src/main/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql
ca57de5
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 61aadf0
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 9269b13
ambari-server/src/main/resources/custom_action_definitions/system_action_definitions.xml
6304baf
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java
3ec9cb3
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ActionResourceProviderTest.java
96995b4
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/RequestResourceProviderTest.java
65efc63
ambari-server/src/test/java/org/apache/ambari/server/customactions/ActionDefinitionManagerTest.java
ec84922
ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java
69b4b08
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
4dedc98
ambari-server/src/test/resources/custom_action_definitions/cust_action_definitions1.xml
9cee575
ambari-server/src/test/resources/custom_action_definitions_invalid/cust_action_definitions_invalid.xml
PRE-CREATION
Diff: https://reviews.apache.org/r/47783/diff/
Testing
-------
Manually tested, newly created cluster and upgrade
# Local test results:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 1:15:22.164s
[INFO] Finished at: Tue May 24 13:28:21 EDT 2016
[INFO] Final Memory: 59M/1807M
[INFO] ------------------------------------------------------------------------
#Jenkins test results: PENDING
Thanks,
Robert Levas
