-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47962/#review135277
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On May 27, 2016, 4:28 p.m., Juanjo  Marron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47962/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 4:28 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16848
>     https://issues.apache.org/jira/browse/AMBARI-16848
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for PIG service 
> scripts in common-servicesPython code at at common-services level used 
> generic imports form resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for STORM, TEZ and 
> ZEPPELIN service scripts in common-services
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_windows.py
>  88e6246 
>   
> ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez.py
>  198674d 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/service_check.py
>  5dfdcad 
> 
> Diff: https://reviews.apache.org/r/47962/diff/
> 
> 
> Testing
> -------
> 
> Passed mvn clean test -DskipSurefireTests
> STORM, TEZ and ZEPPELIN  fresh installation and service check
> 
> Hadoop QA added a comment - Yesterday
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12806417/AMBARI-16848.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7000//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7000//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Reply via email to