> On May 24, 2016, 12:25 a.m., Jaimin Jetly wrote:
> > Sangeeta Ravindran, Lets please add minified version of moment.js for 
> > 2.13.0 version.

Hello Jaimin,

I have attached a new patch with the minified version of moment.js 2.13.0. Can 
you please review?

Thanks,
Sangeeta


- Sangeeta


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47746/#review134482
-----------------------------------------------------------


On May 23, 2016, 11:50 p.m., Sangeeta Ravindran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47746/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 11:50 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: ambari-16017
>     https://issues.apache.org/jira/browse/ambari-16017
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The latest stable version of Moment.js is 2.13.0.
> This task is for updating the version of Moment.js used in
> 
> contrib/views/slider/src/main/resources/ui/vendor/scripts/common/
> ambari-web/vendor/scripts
> 
> 
> Diffs
> -----
> 
>   ambari-web/vendor/scripts/moment.js fe0e19c 
>   contrib/views/slider/src/main/resources/ui/vendor/scripts/common/moment.js 
> b40374b 
> 
> Diff: https://reviews.apache.org/r/47746/diff/
> 
> 
> Testing
> -------
> 
> Manual testing - setting timezone in User Settings.
> Slider view - application start time.
> 
> Tests ran clean for ambari-web 
> 
> 27834 tests complete (42 seconds)
>   154 tests pending
> 
> Tests ran clean for contrib/views/slider
> Took 9506ms to run 345 tests. 345 passed, 0 failed.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Reply via email to