-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47933/
-----------------------------------------------------------

(Updated May 27, 2016, 3:58 p.m.)


Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, Sandor 
Magyari, Sumit Mohanty, and Swapan Shridhar.


Changes
-------

Moved `org.apache.ambari.server.state.kerberos.eval` to 
`org.apache.ambari.server.collections`.


Bugs: AMBARI-16437
    https://issues.apache.org/jira/browse/AMBARI-16437


Repository: ambari


Description
-------

Add conditional constraints for Kerberos identities to control when they are 
created. For example if Kerberos Identity should only be created (and 
distributed) for a component when some other component or service is installed. 

An example of this would be
```
{
  "name": "/HIVE/HIVE_SERVER/hive_server_hive",
  "principal": {
    "configuration": "hive-interactive-site/hive.llap.daemon.service.principal"
  },
  "keytab": {
    "configuration": "hive-interactive-site/hive.llap.daemon.keytab.file"
  },
  "when" : {
      "contains" : ["services", "HIVE"]
  }
}
```

Note the "`when`" clause. This indicates that this identity should only be 
processed when the set of services contains "HIVE".  An alternative to this 
would be to test the set of components for a certain component.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/collections/Predicate.java 
PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/PredicateUtils.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/AndPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/ContainsPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/ContextTransformer.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/DelegatedMultiplePredicateContainer.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/DelegatedSinglePredicateContainer.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/EqualsPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/NotPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/OperationPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/OrPredicate.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/collections/functors/PredicateClassFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 c67c55d 
  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/AbstractPrepareKerberosServerAction.java
 0dbd357 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/AbstractKerberosDescriptorContainer.java
 bb2ed1c 
  
ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptor.java
 d31dd21 
  
ambari-server/src/test/java/org/apache/ambari/server/collections/PredicateUtilsTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/AndPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/ContainsPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/ContextTransformerTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/EqualsPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/NotPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/collections/functors/OrPredicateTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
 5393fd6 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosDescriptorTest.java
 d80d7cc 
  
ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/KerberosIdentityDescriptorTest.java
 0ea7b26 

Diff: https://reviews.apache.org/r/47933/diff/


Testing
-------

Manually tested 

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Reply via email to