-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47993/#review135348
-----------------------------------------------------------


Ship it!




Ship It!

- Zhe (Joe) Wang


On May 27, 2016, 11:14 p.m., Jaimin Jetly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47993/
> -----------------------------------------------------------
> 
> (Updated May 27, 2016, 11:14 p.m.)
> 
> 
> Review request for Ambari, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16940
>     https://issues.apache.org/jira/browse/AMBARI-16940
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> The work revamps the UX for leveraging VDF(Version Definition File) feature 
> of ambari.
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html 9344f15 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
>  47b72e6 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsEditCtrl.js
>  22ec5ae 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsListCtrl.js
>  3a8233a 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
> 2d51ece 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/AddVersionModal.js
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/ConfirmationModal.js
>  4576a40 
>   ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
> 96f9c9f 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Utility.js 
> PRE-CREATION 
>   ambari-admin/src/main/resources/ui/admin-web/app/styles/main.css 4434908 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/modals/AddVersionModal.html
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/modals/ConfirmationModal.html
>  b11f6bb 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/modals/publicRepoDisabled.html
>  PRE-CREATION 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html
>  3de92c1 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
>  f3f2d86 
>   ambari-web/app/assets/test/tests.js c654dac 
>   ambari-web/app/controllers/installer.js 43a5e4a 
>   ambari-web/app/controllers/wizard/step0_controller.js aa3541a 
>   ambari-web/app/controllers/wizard/step1_controller.js 3eb5d1b 
>   ambari-web/app/controllers/wizard/step3_controller.js 38bb5d7 
>   ambari-web/app/controllers/wizard/step4_controller.js 0575f07 
>   ambari-web/app/controllers/wizard/step7_controller.js c3b98b5 
>   ambari-web/app/mappers/stack_mapper.js ab1d6a8 
>   ambari-web/app/messages.js 29ca44c 
>   ambari-web/app/models/repository.js 8ad20ce 
>   ambari-web/app/models/stack.js 6023566 
>   ambari-web/app/models/stack_version/service_simple.js 13ca381 
>   ambari-web/app/routes/installer.js b8b9532 
>   ambari-web/app/styles/application.less 32c88fd 
>   ambari-web/app/styles/common.less 326d404 
>   ambari-web/app/templates/wizard/step1.hbs 56c62a2 
>   
> ambari-web/app/templates/wizard/step1/public_option_disabled_window_body.hbs 
> PRE-CREATION 
>   ambari-web/app/templates/wizard/step1/vdf_upload.hbs PRE-CREATION 
>   ambari-web/app/utils/array_utils.js 643ed67 
>   ambari-web/app/views/wizard/step1_view.js a7af383 
>   ambari-web/karma.conf.js 1a03381 
>   ambari-web/test/controllers/installer_test.js 303c8a4 
>   ambari-web/test/controllers/wizard/step1_test.js PRE-CREATION 
>   ambari-web/test/mixins/common/configs/config_recommendation_parser_test.js 
> 8572772 
>   ambari-web/test/utils/array_utils_test.js ec7c5d8 
>   ambari-web/test/views/common/host_progress_popup_body_view_test.js 282d31c 
>   ambari-web/test/views/wizard/step1_view_test.js 070cb59 
> 
> Diff: https://reviews.apache.org/r/47993/diff/
> 
> 
> Testing
> -------
> 
> Tested ambari-web and ambari-admin view manually:
> Verified that unit tests for ambari-web and ambari-admin passes successfully
> 
> ambari-web:
>   27900 tests complete (29 seconds)
>   154 tests pending
>   
> ambari-admin:
>   phantomJS 1.9.7 (Mac OS X): Executed 71 of 71 SUCCESS (0.467 secs / 0.454 
> secs)
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Reply via email to