> On May 29, 2016, 7:53 p.m., Sandor Magyari wrote: > > Ship It! > > Sandor Magyari wrote: > Could you please add a small unit test.
Looks like upgrades on the servicecomponentdesiredstate table are intentionally skipped in unit tests. Plese see UpgradeCatalog240Test.java, comment in line 182 (in version 87b0a24 of the file). - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47985/#review135442 ----------------------------------------------------------- On May 27, 2016, 8:54 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47985/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 8:54 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver > Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-16939 > https://issues.apache.org/jira/browse/AMBARI-16939 > > > Repository: ambari > > > Description > ------- > > Some 2.2.0 installations carry old (pre Ambari 1.5) FK constraint names in > their DB schema. Upgrade script knows the constraints under a different name > so can't drop them. Fix tries to drop the constraint with both their old and > new names. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > dbbf477 > > Diff: https://reviews.apache.org/r/47985/diff/ > > > Testing > ------- > > - Run all unit tests in ambari-server, all passed > - Manually tested upgrading a 2.2.0 cluster having the old constraint names > to 2.4 > - Manually tested upgrading a 2.2.0 cluster having the new constraint names > to 2.4 > > > Thanks, > > Balázs Bence Sári > >
