----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48036/#review135636 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java (lines 102 - 103) <https://reviews.apache.org/r/48036/#comment200659> If this is getting changed to a HOST type, then the CheckDescription enum should be changed to PrereqCheckType.HOST. Hmm, but this is really a service-based check (SNN must be deleted). Maybe just make the host name where it was found to be informational rather than the getFailedOn(). And in fact, getFailedOn() would be HDFS, not SNN since it's a service and SNN is a component. Either way, should make sure a test covers this appropriately. - Nate Cole On May 30, 2016, 9:18 a.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48036/ > ----------------------------------------------------------- > > (Updated May 30, 2016, 9:18 a.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-16953 > https://issues.apache.org/jira/browse/AMBARI-16953 > > > Repository: ambari > > > Description > ------- > > STR: > # Deploy ambari with HDP2.2 > # Register and install HDP2.5 > # Click "Upgrade" > # Look at the Rolling Upgrade checks > Result: Service name SECONDARY_NAMENODE shown instead of Host name on popup > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java > 4893098 > > Diff: https://reviews.apache.org/r/48036/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Dmitro Lisnichenko > >
