-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47526/#review135725
-----------------------------------------------------------




contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
(line 146)
<https://reviews.apache.org/r/47526/#comment200775>

    js can still interpet without the semicolons, but better to add them.


- Alejandro Fernandez


On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47526/
> -----------------------------------------------------------
> 
> (Updated May 19, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16675
>     https://issues.apache.org/jira/browse/AMBARI-16675
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Earliar : hive jobs with referrer only as 'job' were being shown in history 
> 
> In this patch : all the jobs including sample, explain, visual explain will 
> be shown which was the cause for recent jobs not showning.
> 
> 
> Diffs
> -----
> 
>   
> contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
>  e646fd7 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
> 9584508 
>   contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 
> 848bee8 
> 
> Diff: https://reviews.apache.org/r/47526/diff/
> 
> 
> Testing
> -------
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Reply via email to