----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47922/#review135749 -----------------------------------------------------------
Ship it! Ship It! - Jayush Luniya On May 26, 2016, 10:59 p.m., Juanjo Marron wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47922/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 10:59 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt. > > > Bugs: AMBARI-16669 > https://issues.apache.org/jira/browse/AMBARI-16669 > > > Repository: ambari > > > Description > ------- > > Python code at at common-services level used generic imports form > resource_management (from resource_management import *) > Ideally, for easier code tracking and performance, these import should be > more specific, such as: > from resource_management.libraries.script.script import Script > from resource_management.core.resources.system import Directory > This patch cleans up import * from resource_management for KNOX service > scripts in common-services > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py > fbd879f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py > 1917369 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_ldap.py > dee0154 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 5d454de > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py > e7a3747 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/service_check.py > 5e9b89e > > Diff: https://reviews.apache.org/r/47922/diff/ > > > Testing > ------- > > Passed mvn clean test -DskipSurefireTests > KNOX fresh installation and service check > > Hadoop QA added a comment - 7 minutes ago > -1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12805363/AMBARI-16669.patch > against trunk revision . > +1 @author. The patch does not contain any @author tags. > -1 tests included. The patch doesn't appear to include any new or modified > tests. > Please justify why no new tests are needed for this patch. > Also please list what manual steps were performed to verify this patch. > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > +1 core tests. The patch passed unit tests in ambari-server. > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/6985//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/6985//console > This message is automatically generated. > > > Thanks, > > Juanjo Marron > >
