-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48088/#review135788
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
 (line 197)
<https://reviews.apache.org/r/48088/#comment200836>

    Would contains() be clearer?



ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
 (line 218)
<https://reviews.apache.org/r/48088/#comment200837>

    Maybe log that you're skipping it?


- Jonathan Hurley


On May 31, 2016, 3:48 p.m., Nate Cole wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48088/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 3:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Jayush 
> Luniya.
> 
> 
> Bugs: AMBARI-16971
>     https://issues.apache.org/jira/browse/AMBARI-16971
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Stack VDF loaded via hdp_urlinfo.json may contain OS families that are not 
> supported by the stack.  They should not be included in the merged Version 
> Definition
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/resources/os_family.json 
> c7b38aa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/LatestRepoCallable.java
>  a332308 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java
>  e494c44 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProviderTest.java
>  9f7a90f 
>   ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/hdp.json f80fc0a 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/repos/version-2.2.0.4-124-suse11.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48088/diff/
> 
> 
> Testing
> -------
> 
> Manual.  Automated pending.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Reply via email to